[Kdenlive-devel] [PATCH 06/14] abstractmonitor.h: initialize analyseAudio to false

Mikko Rapeli mikko.rapeli at iki.fi
Sun Jul 22 18:28:14 UTC 2012


Hope it's the correct default. Found by Coverity:

 42    /** @brief Build an abstract MLT Renderer
 43     *  @param name A unique identifier for this renderer
 44     *  @param winid The parent widget identifier (required for SDL display). Set to 0 for OpenGL rendering
 45     *  @param profile The MLT profile used for the renderer (default one will be used if empty). */
CID 709307: Uninitialized scalar field (UNINIT_CTOR)
Non-static class member ""analyseAudio"" is not initialized in this constructor nor in any functions that it calls.
 46    AbstractRender(Kdenlive::MONITORID name, QWidget *parent = 0):QObject(parent), sendFrameForAnalysis(false), m_name(name) {};
 47
 48    /** @brief Destroy the MLT Renderer. */
 49    virtual ~AbstractRender() {};
 50
 51    /** @brief This property is used to decide if the renderer should convert it's frames to QImage for use in other Kdenlive widgets. */
 52    bool sendFrameForAnalysis;
 53
 54    /** @brief This property is used to decide if the renderer should send audio data for monitoring. */
Class member declaration for ""analyseAudio"".
 55    bool analyseAudio;
---
 src/abstractmonitor.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/abstractmonitor.h b/src/abstractmonitor.h
index 5eea227..0a82128 100644
--- a/src/abstractmonitor.h
+++ b/src/abstractmonitor.h
@@ -43,7 +43,7 @@ Q_OBJECT public:
      *  @param name A unique identifier for this renderer
      *  @param winid The parent widget identifier (required for SDL display). Set to 0 for OpenGL rendering
      *  @param profile The MLT profile used for the renderer (default one will be used if empty). */
-    explicit AbstractRender(Kdenlive::MONITORID name, QWidget *parent = 0):QObject(parent), sendFrameForAnalysis(false), m_name(name) {};
+    explicit AbstractRender(Kdenlive::MONITORID name, QWidget *parent = 0):QObject(parent), sendFrameForAnalysis(false), analyseAudio(false), m_name(name) {};
 
     /** @brief Destroy the MLT Renderer. */
     virtual ~AbstractRender() {};
-- 
1.7.10.4





More information about the Kdenlive mailing list