[Kdenlive-devel] [PATCH 00/46] Simple krazy fixes

Mikko Rapeli mikko.rapeli at iki.fi
Sat Jul 14 07:55:47 UTC 2012


Hello,

Here's another set of simple krazy fixes. They have been developed and tested
on top of the previous 37 patches I sent in June. Basically there are just
three changes: use char for singe characters instead of strings,
make class constructors with required args explicit and
use const & with foreach loops where possible.

kdenlive compiles and I able to edit and play around with my test projects
as before.

Mikko Rapeli (46):
  kdenlive_render.cpp: Use char for single character
  lideshowclip.cpp: Use char for single character
  meltjob.cpp: Use char for single character
  docclipbase.cpp: Use char for single character
  recmonitor.cpp: Use char for single character
  spacerdialog.cpp: Use char for single character
  titlewidget.cpp: Use char for single character
  clipstabilize.cpp: Use char for single character
  archivewidget.cpp: Use char for single character
  trackview.cpp: Use char for single character
  clipitem.cpp: Use char for single character
  transitionsettings.cpp: Use char for single character
  wizard.cpp: Use char for single character
  vectorscope.cpp: Use char for single character
  audiospectrum.cpp: Use char for single character
  abstractclipitem.cpp: Use char for single character
  renderwidget.cpp: Use char for single character
  kdenlivesettingsdialog.cpp: Use char for single character
  transition.cpp: Use char for single character
  projectsettings.cpp: Use char for single character
  unicodedialog.cpp: Use char for single character
  trackdialog.cpp: Use char for single character
  customtrackview.cpp: Use char for single character
  encodingprofilesdialog.cpp: Use char for single character
  renderer.cpp: Use char for single character
  parametercontainer.cpp: Use char for single character
  collapsibleeffect.cpp: Use char for single character
  dragvalue.cpp: Use char for single character
  mainwindow.cpp: Use char for single character
  keyframeedit.cpp: Use char for single character
  backupwidget.cpp: Use char for single character
  parameterplotter.cpp: Use char for single character
  stopmotion.cpp: Use char for single character
  clipmanager.cpp: Use char for single character
  documentchecker.cpp: Use char for single character
  cliptranscode.cpp: Use char for single character
  projectlist.cpp: Use char for single character
  kthumb.cpp: Use char for single character
  openclipart.cpp: Use char for single character
  archiveorg.cpp: Use char for single character
  resourcewidget.cpp: Use char for single character
  mltdevicecapture.cpp: Use char for single character
  clipproperties.cpp: Use char for single character
  kdenlivedoc.cpp: Use char for single character
  Make class constructors with required args explicit
  Use const & with foreach loops where possible

 renderer/kdenlive_render.cpp                      |    2 +-
 src/abstractclipitem.cpp                          |    2 +-
 src/abstractmonitor.h                             |    4 +--
 src/archivewidget.cpp                             |   26 +++++++-------
 src/archivewidget.h                               |    2 +-
 src/beziercurve/beziersplinewidget.h              |    2 +-
 src/choosecolorwidget.h                           |    2 +-
 src/clipitem.cpp                                  |   28 +++++++--------
 src/clipmanager.cpp                               |    2 +-
 src/clipproperties.cpp                            |    4 +--
 src/clipstabilize.cpp                             |    4 +--
 src/cliptranscode.cpp                             |    2 +-
 src/customtrackview.cpp                           |    8 ++---
 src/databackup/backupwidget.cpp                   |   10 +++---
 src/docclipbase.cpp                               |    4 +--
 src/documentchecker.cpp                           |   12 +++----
 src/dragvalue.cpp                                 |    4 +--
 src/dragvalue.h                                   |    2 +-
 src/dvdwizardvob.h                                |    2 +-
 src/effectstack/collapsibleeffect.cpp             |    2 +-
 src/effectstack/effectstackview2.h                |    2 +-
 src/effectstack/parametercontainer.cpp            |    2 +-
 src/effectstackedit.h                             |    2 +-
 src/encodingprofilesdialog.cpp                    |   14 ++++----
 src/encodingprofilesdialog.h                      |    2 +-
 src/geometrywidget.cpp                            |    2 +-
 src/kdenlivedoc.cpp                               |   12 +++----
 src/kdenlivesettingsdialog.cpp                    |   40 ++++++++++-----------
 src/keyframeedit.cpp                              |    4 +--
 src/kis_curve_widget.h                            |    2 +-
 src/kthumb.cpp                                    |    2 +-
 src/lib/audio/audioEnvelope.h                     |    2 +-
 src/mainwindow.cpp                                |   24 ++++++-------
 src/mltdevicecapture.cpp                          |    8 ++---
 src/monitoreditwidget.h                           |    2 +-
 src/monitorscene.h                                |    2 +-
 src/onmonitoritems/rotoscoping/bpointitem.h       |    2 +-
 src/onmonitoritems/rotoscoping/splineitem.h       |    2 +-
 src/parameterplotter.cpp                          |   20 +++++------
 src/profilesdialog.h                              |    2 +-
 src/projectlist.cpp                               |   22 ++++++------
 src/projectsettings.cpp                           |   14 ++++----
 src/projecttree/meltjob.cpp                       |   14 ++++----
 src/projecttree/proxyclipjob.cpp                  |   12 +++----
 src/recmonitor.cpp                                |   10 +++---
 src/renderer.cpp                                  |    2 +-
 src/renderwidget.cpp                              |   10 +++---
 src/scopes/abstractscopewidget.h                  |    2 +-
 src/scopes/audioscopes/abstractaudioscopewidget.h |    2 +-
 src/scopes/audioscopes/audiospectrum.cpp          |    2 +-
 src/scopes/colorscopes/abstractgfxscopewidget.h   |    2 +-
 src/scopes/colorscopes/vectorscope.cpp            |    2 +-
 src/slideshowclip.cpp                             |    4 +--
 src/slideshowclip.h                               |    2 +-
 src/smallruler.h                                  |    2 +-
 src/spacerdialog.cpp                              |    2 +-
 src/stopmotion/capturehandler.h                   |    2 +-
 src/stopmotion/stopmotion.cpp                     |    6 ++--
 src/timecodedisplay.h                             |    2 +-
 src/titlewidget.cpp                               |    6 ++--
 src/trackdialog.cpp                               |    2 +-
 src/trackdialog.h                                 |    2 +-
 src/tracksconfigdialog.h                          |    2 +-
 src/trackview.cpp                                 |    6 ++--
 src/transition.cpp                                |    2 +-
 src/transitionsettings.cpp                        |    2 +-
 src/transitionsettings.h                          |    2 +-
 src/unicodedialog.cpp                             |    4 +--
 src/utils/abstractservice.h                       |    2 +-
 src/utils/archiveorg.cpp                          |    4 +--
 src/utils/archiveorg.h                            |    2 +-
 src/utils/freesound.h                             |    2 +-
 src/utils/openclipart.cpp                         |    2 +-
 src/utils/openclipart.h                           |    2 +-
 src/utils/resourcewidget.cpp                      |    2 +-
 src/utils/resourcewidget.h                        |    2 +-
 src/wizard.cpp                                    |   10 +++---
 src/wizard.h                                      |    2 +-
 testingArea/audioOffset.cpp                       |    2 +-
 79 files changed, 223 insertions(+), 223 deletions(-)

-- 
1.7.10.4





More information about the Kdenlive mailing list