[Kdenlive-devel] [PATCH 10/46] trackview.cpp: Use char for single character

Mikko Rapeli mikko.rapeli at iki.fi
Sat Jul 14 07:55:57 UTC 2012


Should be faster than using a full string. Found by krazy.
---
 src/trackview.cpp |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/trackview.cpp b/src/trackview.cpp
index 9cda82d..af723ce 100644
--- a/src/trackview.cpp
+++ b/src/trackview.cpp
@@ -641,7 +641,7 @@ int TrackView::slotAddProjectTrack(int ix, QDomElement xml, bool locked, QDomNod
                     QString prodId = clip->getId();
                     if (clip->clipType() == PLAYLIST || clip->clipType() == AV || clip->clipType() == AUDIO) {
                         // We need producer for the track
-                        prodId.append("_" + QString::number(ix));
+                        prodId.append('_' + QString::number(ix));
                     }
                     elem.setAttribute("producer", prodId);
                     producerReplacementIds.insert(idString, prodId);
@@ -671,7 +671,7 @@ int TrackView::slotAddProjectTrack(int ix, QDomElement xml, bool locked, QDomNod
                         for (int i = 0; i < producers.count(); i++) {
                             QDomElement prod = producers.at(i).toElement();
                             QString mltProdId = prod.attribute("id");
-                            if (mltProdId == prodId || mltProdId.startsWith(prodId + "_")) {
+                            if (mltProdId == prodId || mltProdId.startsWith(prodId + '_')) {
                                 // Found parent producer, clone it
                                 QDomElement clone = prod.cloneNode().toElement();
                                 clone.setAttribute("id", prodId);
@@ -972,7 +972,7 @@ void TrackView::adjustparameterValue(QDomNodeList clipeffectparams, const QStrin
 		    QString fr = kfrs.at(l).section('=', 0, 0);
                     double val = locale.toDouble(kfrs.at(l).section('=', 1, 1));
                     //kfrs[l] = fr + ":" + locale.toString((int)(val * fact));
-                    kfrs[l] = fr + ":" + QString::number((int) (offset + val * fact));
+                    kfrs[l] = fr + ':' + QString::number((int) (offset + val * fact));
                 }
                 e.setAttribute("keyframes", kfrs.join(";"));
             } else if (type == "double" || type == "constant") {
-- 
1.7.10.4





More information about the Kdenlive mailing list