[Kdenlive-devel] Coverity scan

[Till Theato]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/01/2012 09:45 PM, Mikko Rapeli wrote:
> On Sat, Jun 30, 2012 at 09:56:53AM +0200, jb wrote:
>> On Friday 29 June 2012 12:37:50 Mikko Rapeli wrote:
>>> Hi JB and others,
>>> 
>>> How about registering Kdenlive to Coverity scan program to get
>>> some static analysis runs and results?
>>> 
>>> http://scan.coverity.com/developers-faq.html
>>> 
>>> If you are too busy, I can try to handle the process but only
>>> with your permission.
>>> 
>> 
>> Hello Mikko.
>> 
>> Sorry for the late reply, I am taking a few days away from my
>> computer.. Thanks for your patches. Don't you have an account on
>> identity.kde.org? Maybe you could create an account so that you
>> can commit the patches yourself.
>> 
>> Otherwise I will commit them in the next days / weeks.
> 
> Ok, I created an account with username mrapeli but I would like to
> pass my changes through some kind of review. I have another set of
> 42 simple fixes for krazy's findings on the way as well.
> 
>> If you have time to create an account on Coverty, that could be
>> great.
> 
> Thanks, I'll kick this off and Cc you in the emails.
> 
>> However, Till is currently doing some major rewrite, and I think
>> we should make a decision on what is the current workflow between
>> the refactoring branch and trunk, so that we don't duplicate work
>> because I am not sure we can merge refactoring into trunk.
> 
> Yes, I'm aware of this. If the refactoring is committed as smaller 
> atomic/logical changes to git, then rebasing or merging should not
> be a big deal. It would also help with bisecting and reverts if a
> regression creeps in.

Hey Mikko,

The refactored code is completely different, so rebasing/merging
definitely won't work. It's a bit confusing currently because the old
code is still there, but nothing outside src/core and src/plugins
(besides main.c) is used.

> But this is up to you. I'm ready to rebase and rework my changes.
> 
> -Mikko
> 


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iEYEARECAAYFAk/wqikACgkQzwEyz7QP6nS5VwCgktnZikcZNDJ1xvyegUXimoCq
/mgAoMoXvCjHC1etvf2CFetfr4j5cZTy
=KQzR
-----END PGP SIGNATURE-----