[Kdenlive-devel] [PATCH 00/16] Coverity fixes

Mikko Rapeli mikko.rapeli at iki.fi
Fri Aug 10 12:17:01 UTC 2012


Here's another set of fixes for Coverity's findings. I'm not sure all of them
do the right thing on error paths so please have a look. Tested locally
with a few projects and nothing seems to break.

The patches are also available in coverity branch of git tree:

https://github.com/mcfrisk/kdenlive.git

Mikko Rapeli (16):
  histogramgenerator.cpp: check for division by zero
  effectstackview2.cpp: check for null pointer
  effectstackview2.cpp: check for null
  audioCorrelationInfo.cpp: check for division by zero
  audioEnvelope.cpp: check for division by zero
  meltjob.cpp: initialize addClipToProject
  dvdwizardvob.cpp: check return value
  kthumb.cpp: check for division by zero
  kis_cubic_curve.cpp: initialize variables
  markerdialog.cpp: add break to switch case
  projectlist.cpp: check for null before referencing
  projectlistview.cpp: check for null pointer
  projectsettings.cpp: return if open() fails
  renderer.cpp: check for null pointers
  titledocument.cpp: check return value from open()
  thumbnailer/westleypreview.cpp: check for division by zero

 src/colorcorrection/histogramgenerator.cpp |    5 ++++-
 src/dvdwizardvob.cpp                       |    5 ++++-
 src/effectstack/effectstackview2.cpp       |    7 ++++---
 src/kis_cubic_curve.cpp                    |    5 +++--
 src/kthumb.cpp                             |    8 ++++++--
 src/lib/audio/audioCorrelationInfo.cpp     |    3 +++
 src/lib/audio/audioEnvelope.cpp            |    4 ++++
 src/markerdialog.cpp                       |    1 +
 src/projectlist.cpp                        |    8 ++++----
 src/projectlistview.cpp                    |    2 +-
 src/projectsettings.cpp                    |    3 ++-
 src/projecttree/meltjob.cpp                |    3 ++-
 src/renderer.cpp                           |   18 ++++++++++++++----
 src/titledocument.cpp                      |    3 ++-
 thumbnailer/westleypreview.cpp             |    1 +
 15 files changed, 55 insertions(+), 21 deletions(-)

-- 
1.7.10.4





More information about the Kdenlive mailing list