[Kdenlive-devel] Getting ready ofr the 0.8.2 release

[Dan Dennedy]

On Sun, Aug 28, 2011 at 3:01 PM, Till Theato <root at ttill.de> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08/28/2011 11:57 PM, Dan Dennedy wrote:
>> On Sun, Aug 28, 2011 at 1:47 PM, Till Theato <root at ttill.de>
>> wrote:
>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>>>
>>> On 07/05/2011 06:32 PM, Dan Dennedy wrote:
>>>> On Tue, Jul 5, 2011 at 3:54 AM, jb <jb at kdenlive.org> wrote:
>>>>> Hi all.
>>>>>
>>>>> I think I fixed most major issues for the 0.8.2 release. I
>>>>> created the 0.8.2 info page (
>>>>> http://kdenlive.org/discover/0.8.2 ), and will soon post a
>>>>> blog entry to inform users.
>>>>>
>>>>> If it's ok for everyone, I would like to enter string freeze
>>>>>  tomorrow (on the 6th of July).
>>>>>
>>>>> Then, we can wait 2 weeks to give some time for the
>>>>> translators and get some feedback from testers, so that the
>>>>> release can be made around the 20th of July.
>>>
>>> We almost made it :D
>>>
>>>>>
>>>>> One of the last thing on my list is to check that profile /
>>>>> mlt_profile conflict in render profiles.
>>>>
>>>> It is as easy as removing all profile=  in the current xml.
>>>> Then, wherever that occurred means a rule needs to be
>>>> enforced: only show render presets compatible to project
>>>> settings (same fps). Then, as long as the preset contains s=
>>>> and aspect=, it will work fine since it will engage the
>>>> consumer producer.
>>>
>>> Hi, thanks for the tip! Done in r5845.
>>
>> Big mistake. You misunderstood. MLT does not automatically invoke
>> the consumer producer in the presence of s=. It is kdenlive that
>> does it and must continue to do it. Also, it is ok to use
>> mlt_profile as long as you only offer it when the fps matches the
>> project settings. My commit yesterday r5839 fixes that. Please
>> revert this commit because it is a regression.
>
> I couldn't find any difference in the rendered files...

You need to understand the purpose of the consumer producer in order
to make a negative test case and test it. I created a project using
color clips attached here for you. See how it looks in preview
monitor. Then, render to HDV 720. Next, render to DV AVI 16:9 (being
optimistic that user knows they want 16:9 output for a 16:9 project).
See how they look. Now revert the commit with 'svn merge -c -5845 .'
and retry the tests.

Technically, it is OK to have mlt_profile in the render profiles as I
had left it but only because of the "standard" attribute and how it is
being used more strictly now. However, to discourage others from using
it in custom profiles, we can retain the changes you made to replace
its usage with s= and aspect=. It is the code that removes the
consumer producer that is the real regression.

-- 
+-DRD-+
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test.kdenlive
Type: application/x-kdenlive
Size: 7217 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20110828/dba48850/attachment.bin>