[Kdenlive-devel] [PATCH kdenlive 19/27] const parameter as reference

Mikko Rapeli mikko.rapeli at iki.fi
Sun Aug 28 10:24:59 UTC 2011


Found by cppcheck.
---
 src/mltdevicecapture.cpp |    2 +-
 src/mltdevicecapture.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mltdevicecapture.cpp b/src/mltdevicecapture.cpp
index 7998aa2..a60f34a 100644
--- a/src/mltdevicecapture.cpp
+++ b/src/mltdevicecapture.cpp
@@ -504,7 +504,7 @@ void MltDeviceCapture::setOverlay(const QString &path)
     //delete clip;
 }
 
-void MltDeviceCapture::setOverlayEffect(const QString tag, QStringList parameters)
+void MltDeviceCapture::setOverlayEffect(const QString &tag, QStringList parameters)
 {
     if (m_mltProducer == NULL || !m_mltProducer->is_valid()) return;
     Mlt::Service service(m_mltProducer->parent().get_service());
diff --git a/src/mltdevicecapture.h b/src/mltdevicecapture.h
index 30d695c..7ba44c2 100644
--- a/src/mltdevicecapture.h
+++ b/src/mltdevicecapture.h
@@ -89,7 +89,7 @@ Q_OBJECT public:
     void setOverlay(const QString &path);
 
     /** @brief This will add an MLT video effect to the overlay track. */
-    void setOverlayEffect(const QString tag, QStringList parameters);
+    void setOverlayEffect(const QString &tag, QStringList parameters);
 
     /** @brief This will add a horizontal flip effect, easier to work when filming yourself. */
     void mirror(bool activate);
-- 
1.7.5.4





More information about the Kdenlive mailing list