[Kdenlive-devel] [PATCH kdenlive 13/27] const parameter as reference

Mikko Rapeli mikko.rapeli at iki.fi
Sun Aug 28 10:24:53 UTC 2011


Found by cppcheck.
---
 src/effectstackedit.cpp |    2 +-
 src/effectstackedit.h   |    4 ++--
 src/effectstackview.cpp |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/effectstackedit.cpp b/src/effectstackedit.cpp
index 955f0c5..af2b1e5 100644
--- a/src/effectstackedit.cpp
+++ b/src/effectstackedit.cpp
@@ -205,7 +205,7 @@ void EffectStackEdit::updateParameter(const QString &name, const QString &value)
     }
 }
 
-void EffectStackEdit::transferParamDesc(const QDomElement d, ItemInfo info, bool isEffect)
+void EffectStackEdit::transferParamDesc(const QDomElement &d, ItemInfo info, bool isEffect)
 {
     clearAllItems();
     if (m_keyframeEditor) delete m_keyframeEditor;
diff --git a/src/effectstackedit.h b/src/effectstackedit.h
index d277059..ea41b30 100644
--- a/src/effectstackedit.h
+++ b/src/effectstackedit.h
@@ -87,7 +87,7 @@ private:
 
 public slots:
     /** @brief Called when an effect is selected, builds the UI for this effect. */
-    void transferParamDesc(const QDomElement d, ItemInfo info, bool isEffect = true);
+    void transferParamDesc(const QDomElement &d, ItemInfo info, bool isEffect = true);
 
     /** @brief Called whenever(?) some parameter is changed in the gui.
      *
@@ -98,7 +98,7 @@ public slots:
     void slotSyncEffectsPos(int pos);
 
 signals:
-    void parameterChanged(const QDomElement, const QDomElement);
+    void parameterChanged(const QDomElement &, const QDomElement &);
     void seekTimeline(int);
     void displayMessage(const QString&, int);
     void checkMonitorPosition(int);
diff --git a/src/effectstackview.cpp b/src/effectstackview.cpp
index 53cb6c4..92bcfce 100644
--- a/src/effectstackview.cpp
+++ b/src/effectstackview.cpp
@@ -91,7 +91,7 @@ EffectStackView::EffectStackView(Monitor *monitor, QWidget *parent) :
     connect(m_ui.buttonReset, SIGNAL(clicked()), this, SLOT(slotResetEffect()));
     connect(m_ui.checkAll, SIGNAL(stateChanged(int)), this, SLOT(slotCheckAll(int)));
     connect(m_ui.buttonShowComments, SIGNAL(clicked()), this, SLOT(slotShowComments()));
-    connect(m_effectedit, SIGNAL(parameterChanged(const QDomElement, const QDomElement)), this , SLOT(slotUpdateEffectParams(const QDomElement, const QDomElement)));
+    connect(m_effectedit, SIGNAL(parameterChanged(const QDomElement &, const QDomElement &)), this , SLOT(slotUpdateEffectParams(const QDomElement &, const QDomElement &)));
     connect(m_effectedit, SIGNAL(seekTimeline(int)), this , SLOT(slotSeekTimeline(int)));
     connect(m_effectedit, SIGNAL(displayMessage(const QString&, int)), this, SIGNAL(displayMessage(const QString&, int)));
     connect(m_effectedit, SIGNAL(checkMonitorPosition(int)), this, SLOT(slotCheckMonitorPosition(int)));
-- 
1.7.5.4





More information about the Kdenlive mailing list