[Kdenlive-devel] [PATCH kdenlive 11/27] const parameters as reference
Mikko Rapeli
mikko.rapeli at iki.fi
Sun Aug 28 10:24:51 UTC 2011
Found by cppcheck.
---
src/dvdwizardvob.cpp | 4 ++--
src/dvdwizardvob.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/dvdwizardvob.cpp b/src/dvdwizardvob.cpp
index 39e7d37..8b9b0d6 100644
--- a/src/dvdwizardvob.cpp
+++ b/src/dvdwizardvob.cpp
@@ -276,7 +276,7 @@ QString DvdWizardVob::introMovie() const
return m_view.intro_vob->url().path();
}
-void DvdWizardVob::setIntroMovie(const QString path)
+void DvdWizardVob::setIntroMovie(const QString& path)
{
m_view.intro_vob->setUrl(KUrl(path));
m_view.use_intro->setChecked(path.isEmpty() == false);
@@ -338,7 +338,7 @@ bool DvdWizardVob::isWide() const
return (m_view.dvd_profile->currentIndex() == 1 || m_view.dvd_profile->currentIndex() == 3);
}
-void DvdWizardVob::setProfile(const QString profile)
+void DvdWizardVob::setProfile(const QString& profile)
{
if (profile == "dv_pal") m_view.dvd_profile->setCurrentIndex(0);
else if (profile == "dv_pal_wide") m_view.dvd_profile->setCurrentIndex(1);
diff --git a/src/dvdwizardvob.h b/src/dvdwizardvob.h
index 6fd5b7f..58698cf 100644
--- a/src/dvdwizardvob.h
+++ b/src/dvdwizardvob.h
@@ -49,10 +49,10 @@ public:
int duration(int ix) const;
QStringList durations() const;
QStringList chapters() const;
- void setProfile(const QString profile);
+ void setProfile(const QString& profile);
void clear();
void updateChapters(QMap <QString, QString> chaptersdata);
- void setIntroMovie(const QString path);
+ void setIntroMovie(const QString& path);
private:
Ui::DvdWizardVob_UI m_view;
--
1.7.5.4
More information about the Kdenlive
mailing list