[Kdenlive-devel] [PATCH kdenlive 08/27] const parameters as reference

Mikko Rapeli mikko.rapeli at iki.fi
Sun Aug 28 10:24:48 UTC 2011


Found by cppcheck.
---
 src/docclipbase.h   |    4 ++--
 src/projectlist.cpp |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/docclipbase.h b/src/docclipbase.h
index 95e0b6b..b23945d 100644
--- a/src/docclipbase.h
+++ b/src/docclipbase.h
@@ -278,9 +278,9 @@ public slots:
 signals:
     void gotAudioData();
     /** @brief Generate a proxy clip (lower resolution copy) named like the clip's hash. */
-    void createProxy(const QString id);
+    void createProxy(const QString &id);
     /** @brief Abort creation of the proxy clip (lower resolution copy). */
-    void abortProxy(const QString id, const QString proxyPath);
+    void abortProxy(const QString &id, const QString &proxyPath);
 };
 
 #endif
diff --git a/src/projectlist.cpp b/src/projectlist.cpp
index ab15315..69af733 100644
--- a/src/projectlist.cpp
+++ b/src/projectlist.cpp
@@ -1018,8 +1018,8 @@ void ProjectList::slotAddClip(DocClipBase *clip, bool getProperties)
         item = new ProjectItem(m_listView, clip);
     }
     if (item->data(0, DurationRole).isNull()) item->setData(0, DurationRole, i18n("Loading"));
-    connect(clip, SIGNAL(createProxy(const QString)), this, SLOT(slotCreateProxy(const QString)));
-    connect(clip, SIGNAL(abortProxy(const QString, const QString)), this, SLOT(slotAbortProxy(const QString, const QString)));
+    connect(clip, SIGNAL(createProxy(const QString &)), this, SLOT(slotCreateProxy(const QString &)));
+    connect(clip, SIGNAL(abortProxy(const QString &, const QString &)), this, SLOT(slotAbortProxy(const QString, const QString)));
     if (getProperties) {
         m_listView->processLayout();
         QDomElement e = clip->toXML().cloneNode().toElement();
-- 
1.7.5.4





More information about the Kdenlive mailing list