[Kdenlive-devel] keyframable filter geometry

[jb]

On Friday 18 June 2010 20.02:04 jb wrote:
> On Friday 18 June 2010 06.19:20 Dan Dennedy wrote:
> > On Tue, Jun 8, 2010 at 9:43 PM, Dan Dennedy <dan at dennedy.org> wrote:
> > 
> > I see JBM worked on this. Thank you. However, it still does not work.
> > This is because the filter does not have in and out properties set. I
> > tried to locate the place in Kdenlive source to make it add them as
> > they are for filters with "keyframe" parameter, but I could not locate
> > it after a couple of hours of looking and trying different things.
> 
> Ok, I will have a look and fix it.

I think I managed to fix the issue in Kdenlive (svn rev 4525), but I had to 
make a small change to the filter_affine for it to work (see patch below).

Without that patch, the affine transition does not start at the right place when 
using cropped clips in a timeline.

If you think that the problem is somewhere else, let me know.

regards
jb

_____________________________________________________________________________


diff --git a/src/modules/plus/filter_affine.c b/src/modules/plus/filter_affine.c
index 755d16b..d0e3e7c 100644
--- a/src/modules/plus/filter_affine.c
+++ b/src/modules/plus/filter_affine.c
@@ -108,7 +108,7 @@ static mlt_frame filter_process( mlt_filter this, mlt_frame 
frame )
        char *name = mlt_properties_get( MLT_FILTER_PROPERTIES( this ), 
"_unique_id" );
 
        // Assign the current position to the name
-       mlt_properties_set_position( properties, name, mlt_frame_get_position( 
frame ) - mlt_filter_get_in( this ) );
+       mlt_properties_set_position( properties, name, mlt_frame_get_position( 
frame ) );
 
        // Push the frame filter
        mlt_frame_push_service( frame, this );
~