[Kdenlive-devel] Color correction tools: How and where to implement them?

[Till Theato]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/15/2010 09:52 AM, Simon Eugster wrote:
> 2010/7/14 Till Theato <root at ttill.de>:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 07/14/2010 07:13 PM, Dan Dennedy wrote:
>>> On Wed, Jul 14, 2010 at 9:00 AM, Simon Eugster <simon.eu at gmail.com> wrote:
>>>>>> * 3-Way color correction works basically quite well,
>>>>>>   but the usability is terrible.
>>>>>>   If you want to change the blacks, you have to rise the black
>>>>>>   value to see colors in the color picker, and at the end make
>>>>>>   it nearly black again. Would be much better to just chose a
>>>>>>   color and not having to worry about black.
>>>>>>   Also is it not very convenient not to have a live preview.
>>>>>
>>>>> All Kdenlive effects have live preview. So, a simple enhancement to
>>>>> toggle that would help.
>>>>
>>>> Well, there is live preview as soon as the color has changed in the
>>>> widget. But this is only the case when the color picker has been
>>>> closed already. There should be a built-in color picker.
>>>
>>> Yeah, like I suggested for white balance.
>>>
>>
>> I will take a look at this one. Maybe we could also reuse a color
>> selector from krita.
> 
> Perhaps something like the HSV color wheel here
> http://en.wikipedia.org/wiki/Color_wheel would be good because even
> for high black values you still see the color.
> 
> Perhaps a wheel that just ignores the black value (like a YUV wheel
> with fixed Y) would suit even better. Especially as the vectorscope
> uses YUV as well, this would make color corrections much easier. I'm
> currently trying (or, intending to try, should be learning actually)
> to produce a YUV circle for the vectorscope as background, but this
> could also be used for a color wheel later. When I get it, this
> shouldn't even be too difficult.
> Perhaps we'd still need to add the Y component separately.
> 
What I thought of was Krita's Triangle Color Selector
(http://lukast.mediablog.sk/i/colorchoosers/krita-color-choosers.png).
However it is RGB based.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw+y4sACgkQzwEyz7QP6nQ06ACg3hCuaNjscYIveQyyeOwK3M0p
eE8AoIUPnHUPeLvnCCkcY16Qva5B/01F
=1IzO
-----END PGP SIGNATURE-----