[Kdenlive-devel] Crop effect does not work on .kdenlive clips

[Simon Eugster]

2010/8/30 Dan Dennedy <dan at dennedy.org>:
> On Mon, Aug 30, 2010 at 2:07 PM, Dan Dennedy <dan at dennedy.org> wrote:
>> On Mon, Aug 30, 2010 at 11:23 AM, Dan Dennedy <dan at dennedy.org> wrote:
>>> On Mon, Aug 30, 2010 at 8:59 AM, Simon A. Eugster <simon.eu at gmail.com> wrote:
>>>> As the Canon EOS 550D is recording with 1088 px height.
>>>
>>> Note to self: avoid purchasing a camera that does this!
>>>
>>>> When using 1080p as project profile, black borders are created on the
>>>> left/right of the video (scaled down to 1080). So one option is to add a
>>>> Crop effect to every single clip in the timeline and cutting off 8 px from
>>>> the bottom (or the top).
>>>
>>> I wonder if it makes sense at all to change the pixel aspect ratio? I
>>> think that is a little more convenient than crop on each clip.
>>
>> No, bad idea. From a little analysis, I see that 1088 is used because
>> it is an integral number of macroblocks (68*16 = 1088). AVCHD and
>> similar contain crop information in the H.264 parameter sets. However,
>> on the Canon EOS cameras, the sequence parameters sets contain 0 for
>> the cropping fields. There might be signaling elsewhere that ffmpeg
>> does not understand because interestingly Quicktime shows it as 1080
>> (VLC as 1088). Or, Quicktime may have baked in some heuristic, which

I'd think so.
Stu Maschwitz has written about Quicktime and the EOS 7D as well in
his blog, the entry called «Quicktime 7.6 Fixes 5D Movies», to be
found here: http://prolost.com/blog/tag/color?currentPage=4 (I cannot
link the page directly, the link is dead). To me this also sounds like
a «Fix the EOS 7D movies only» change (and maybe I'm mistaken).

>> is what I am considering. The logic would very constrained: if no
>> override, height is 1088, and project aspect ratio is 16:9 crop 8 rows
>> from the bottom.
>
> I attached a patch that does this. Give it a try.

That's the one guessing whether it's an EOS movie, right? Because I
wanted to try the crop effect but couldn't do it as there were no
black bars anymore in the 1080p project. :)
Other videos are unaffected. I couldn't find any bugs in my short test.

Cool!

Simon