[Kdenlive-devel] Color correction tools: How and where to implement them?

[Till Theato]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/09/2010 06:43 AM, Dan Dennedy wrote:
> On Sun, Aug 8, 2010 at 5:23 AM, jb <jb at kdenlive.org> wrote:
>> On Thursday 05 August 2010 07:47:43 Dan Dennedy wrote:
>>
>>> I have this change working good in my local copy, but I had to move
>>> the location of the consumer-frame-show event in the MLT sdl consumer
>>> to occur _after_ the consumer was finished with the frame's image.
>>> Then, basically, I made the event handler in Kdenlive emit a signal
>>> with a QImage, which the Qt signals-slots system takes care of queuing
>>> between the threads. The slot in the AbstractScopeWidget then updates
>>> a private QImage, which is then sent into the renderScope methods.
>>>
>>> I can update Kdenlive svn a few days after I commit the MLT change.
>>
>> Thanks for taking care of this. Can you please commit your changes to
>> Kdenlive? I also have something like that in my local copy, so I will compare
>> both ways.
> 
> OK, I did this now. Remember, it requires updating from MLT git head.
> 

The colors in the QImage provided by frameUpdated() are somehow wrong.
This is probably because Qt uses ARGB but MLT RGBA and no conversation
is done?
Anyway the scopes have a nice speed now!

regards ttill
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxf7jMACgkQzwEyz7QP6nTaJwCeN70iZy1WrXFF54EKGSI4PcHR
DI8AoIP8s/3cqEsIb11iMv4THqoj2eoR
=RY6v
-----END PGP SIGNATURE-----