[Kdenlive-devel] Color correction tools: How and where to implement them?

[amir]

On Monday 09 August 2010 07:43:00 Dan Dennedy wrote:
> On Sun, Aug 8, 2010 at
5:23 AM, jb <jb at kdenlive.org> wrote:
> > On Thursday 05 August 2010 07:47:43
Dan Dennedy wrote:
> >> I have this change working good in my local copy,
but I had to move
> >> the location of the consumer-frame-show event in the
MLT sdl consumer
> >> to occur _after_ the consumer was finished with the
frame's image.
> >> Then, basically, I made the event handler in Kdenlive
emit a signal
> >> with a QImage, which the Qt signals-slots system takes
care of queuing
> >> between the threads. The slot in the
AbstractScopeWidget then updates
> >> a private QImage, which is then sent
into the renderScope methods.
> >> 
> >> I can update Kdenlive svn a few
days after I commit the MLT change.
> > 
> > Thanks for taking care of this.
Can you please commit your changes to
> > Kdenlive? I also have something
like that in my local copy, so I will
> > compare both ways.
> 
> OK, I did
this now. Remember, it requires updating from MLT git head.
 
MLT git build
crashes:

make[2]: Entering directory
`/home/amir/disk1/pkg/mlt-git/src/mlt-build/src/modules/qimage'
cc
-march=x86-64 -mtune=generic -O2 -pipe -Wall -fPIC -DPIC   -O2 -pipe
-fomit-frame-pointer -ffast-math    -g -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread -Wall -fPIC -DPIC   -O2 -pipe
-fomit-frame-pointer -ffast-math    -g -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread -I../.. -Wall -fPIC -DPIC   -O2
-pipe -fomit-frame-pointer -ffast-math    -g -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread   -c -o factory.o factory.c
cc
-march=x86-64 -mtune=generic -O2 -pipe -Wall -fPIC -DPIC   -O2 -pipe
-fomit-frame-pointer -ffast-math    -g -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread -Wall -fPIC -DPIC   -O2 -pipe
-fomit-frame-pointer -ffast-math    -g -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread -I../.. -Wall -fPIC -DPIC   -O2
-pipe -fomit-frame-pointer -ffast-math    -g -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread   -c -o producer_qimage.o
producer_qimage.c
cc -march=x86-64 -mtune=generic -O2 -pipe -Wall -fPIC
-DPIC   -O2 -pipe -fomit-frame-pointer -ffast-math    -g
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread -Wall
-fPIC -DPIC   -O2 -pipe -fomit-frame-pointer -ffast-math    -g
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread -I../..
-Wall -fPIC -DPIC   -O2 -pipe -fomit-frame-pointer -ffast-math    -g
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread   -c -o
producer_kdenlivetitle.o producer_kdenlivetitle.c
g++ -march=x86-64
-mtune=generic -O2 -pipe -march=x86-64 -mtune=generic -O2 -pipe -Wall -fPIC
-DPIC   -O2 -pipe -fomit-frame-pointer -ffast-math    -g
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread -Wall
-fPIC -DPIC   -O2 -pipe -fomit-frame-pointer -ffast-math    -g
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread -I../..
-Wall -fPIC -DPIC   -O2 -pipe -fomit-frame-pointer -ffast-math    -g
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DARCH_X86_64 -pthread
-DQT_SHARED -I/usr/include/QtCore -I/usr/include/QtGui -I/usr/include/QtXml
-I/usr/include/QtSvg  -Wno-deprecated   -c -o qimage_wrapper.o
qimage_wrapper.cpp
qimage_wrapper.cpp:46:23: fatal error: exif-data.h: No
such file or directory
compilation terminated.
make[2]: ***
[qimage_wrapper.o] Error 1
make[2]: Leaving directory
`/home/amir/disk1/pkg/mlt-git/src/mlt-build/src/modules/qimage'
make[1]: ***
[all] Error 1
make[1]: Leaving directory
`/home/amir/disk1/pkg/mlt-git/src/mlt-build/src/modules'
make: *** [all]
Error 1
    Aborting...

thanks,
amir