[Kdenlive-devel] Color correction tools: How and where to implement them?

[Till Theato]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/31/2010 03:39 PM, Till Theato wrote:
> On 07/31/2010 09:33 AM, Simon Eugster wrote:
>> 2010/7/30 el jefe delito <eljefedelito at gmail.com>:
>>> On Friday, July 30, 2010 05:34:32 Till Theato wrote:
>>>> in svn r4662 I now added a color picker ("eyedropper").
>>>
>>> While I've not seen this yet and I may be late to the discussion, I generally find that eyedroppers pick too precise of a single colour, when a better goal would be to get the average colour of a region where the eyedropper was used.  A white wall or a blue sky is rarely made up of all of the same shade; more often these areas consist of many, many different colours that appear to the eye to be a single shade.  Usually, only digitally-created images have a solid colour; it would be better to have an eyedropper that selects a small (or large) region rather than a single pixel.
> 
>> I was about to suggest this as well. Quite important feature imho. The
>> radius should be configurable somehow.
> 
>> Something else, we need a different cursor for the color picker. The
>> current one (a cross here) hides the color I'm clicking on at the
>> moment. I could create one if desired.
> 
> 
> When picking only a single color the cursor looks now the same as the
> icon ("color-picker"). Hope this works better.
> 
> I also added picking an average color. You can set the width of a square
> with the cursor being its center. I limited the width to 100 px for now
> because it is very very slow. 50px take 1-2 sec here and 100px a whole
> lot longer. The other point is that you cannot see the edges of the
> square, when moving the cursor. Will have to work on these two things.
> 

Hi again,

now the speed should be a lot better. Big rects still need their time
(let's say 500px or 1000px) but it is acceptable (at least this is what
I think).
For rects with a width larger than 200px you will now also see the
progress in the status bar.

Regarding the cursor: Rects with a size >= 10px now use the kdenlive
select all icon (also used in titler) at the size of the rect. Might
flicker a bit at big sizes or even not show up at all if you choose very
big sizes (larger than height of screen), but it should give you
information on what you are picking on "normal" sizes ;) .

Please test and feel free to give feedback. Would be also nice if
someone could test with non X11 as getting the color is done different
there.

regards ttill



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxVYdcACgkQzwEyz7QP6nTAtwCgvgWWF07L1Uw/trEMnz0xlbUZ
0L4AoKiYIgcmavAtX3B4IstoKen6PqeG
=hFPb
-----END PGP SIGNATURE-----