[Kdenlive-devel] review patch: document loading and validation

[jb]

On Wednesday 10 June 2009 01:44:42 Alberto Villa wrote:
> hi list!
> 
> jb, i've started writing the long time awaited (at least by mads and me :) 
> validation function, but i ended up rewriting a bit of the document loading 
> and conversion parts
> i'd be happy to commit this attached patch, but since the changes are not 
> that little, i'd like you (and mads, maybe) to review it (it's a recursive 
> patch, kompare suggested or you'll get crazy)
> 
> among small fixes, here's what i changed


Hi.

Great! I was not able to apply the patch to fully test (it does not apply successfully because it assumes documentvalidator.* already exists). However I did a quick review and the logic of it seems ok.

So I would suggest that you commit, any problem will probably be detected quickly.

regards
jb