[Kdenlive-devel] Removing some warnings

[jb]

On Saturday 31 May 2008 21:46:34 Fran García wrote:
> Hi,
> I think I removed some of the warnings in the kde4 version, I'd like to
> know what you think.

Hi!

First, thanks for your patch, it's great to have some help.
>-  "sdl_preview"); //consumer;
>+  (char*)"sdl_preview"); //consumer;

I am by no way a c++ expert but I think this could lead to memory leaks. I did 
some search about the warning:

deprecated conversion from string constant to ‘char*’

And it seems the correct fix is to change the "char*" functions to "const 
char*".

Since all those warnings come from the MLT++ bindings, I think the correct fix 
would be to change the MLT++ functions to use const char* instead of char*...

But if someone has a better knowledge of the issue, I am listening.

> For kthumb.cpp:
> -        m_clipManager->setThumbsProgress(m_url, p->value());
> +        m_clipManager->setThumbsProgress(m_url.url(), p->value());

Yes, fixed. I forgot to commit this change.

> And effectstackedit:
> Here the compiler complained about deleting a void* was undefined. As
> far as I can tell, doing that cast to char* should do the trick, but I
> don't really know well the code so maybe I did something stupid with that!

I have no idea about the correct fix for this... Marco ?
The other compile problems you encountered should be fixed now I think.

Regards.
jb