[Bug 160284] bad mmap causes cores in KPCMemoryDevice

[Michael Pyne]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160284         




------- Additional Comments From mpyne purinchu net  2008-06-05 04:28 -------
Sebastian, by the way I'm reading the code the resize should happen before the file is mmaped.  The only reason the size should be different is if the file has never been opened, it will be marked with a size of size of 0.  The cache size passed into mmapFile() will be much higher (but constant!) and so this should only get called once.  Which really is another reason the change didn't need to go in I guess.

However if non-KIconCache users of KPixmapCache resize the cache it possible the file size would change (and in fact, maybe the way I did it is a bug..., what if users want to shrink cache size?).  But I think the code will have already unmapped the file by this point if it's being called from resizeCache.  If not that's a separate bug.

Of course another bug is that QDataStream is not versioned but this one isn't a big deal I don't think.