[Bug 160284] bad mmap causes cores in KPCMemoryDevice

[Lubos Lunak]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160284         
l.lunak kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |l.lunak kde org



------- Additional Comments From l.lunak kde org  2008-06-04 12:00 -------
I may be missing some technical details, but the "fix" with not resizing the file if it would become smaller looks to me just like a workaround. One is not supposed to get SIGBUS with properly handled mmap files. Either updating the file is done using unlink+create new file, in which case the old file doesn't change and therefore there is no problem, or the file is updated only when properly locked, and then again there cannot be invalid accesses. If the code was getting SIGBUS because of changed file size, then the code is broken, and may possibly break under strange circumstances again.