[Bug 158335] New: CMake rules for finding smbc_set_context don't work when samba is in a non-standard place

[Christopher Neufeld]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=158335         
           Summary: CMake rules for finding smbc_set_context don't work when
                    samba is in a non-standard place
           Product: kdelibs
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: kdelibs-bugs kde org
        ReportedBy: kdebugs cneufeld ca


Version:            (using Devel)
Installed from:    Compiled sources
Compiler:          gcc-4.2.2 Compiler compiled from gcc.gnu.org sources
OS:                Linux

When building kdelibs, it decides that I don't have smbc_set_context.  The reason is that it does not know where to look to find my samba include files.  The following patch in the kdelibs tree allows kdebase to notice that I do, in fact, have a library with the required symbol:

Index: cmake/modules/FindSamba.cmake
===================================================================
--- cmake/modules/FindSamba.cmake       (revision 778745)
+++ cmake/modules/FindSamba.cmake       (working copy)
 @ -29,6 +29,7  @
    include(MacroPushRequiredVars)
    macro_push_required_vars()
    set(CMAKE_REQUIRED_LIBRARIES ${CMAKE_REQUIRED_LIBRARIES} ${SAMBA_LIBRARIES})
+   set(CMAKE_REQUIRED_INCLUDES ${CMAKE_REQUIRED_INCLUDES} ${SAMBA_INCLUDE_DIR})
    check_symbol_exists(smbc_set_context "libsmbclient.h" SAMBA_HAVE_SMBC_SET_CONTEXT)
    macro_pop_required_vars()
    # fail if smbc_set_context() was required but hasn't been found