[Kdelibs-bugs] [PATCH] kdelibs/kio/kfile/kopenwithdialog.cpp
Allen Winter
winter at kde.org
Mon Nov 12 13:42:21 CET 2007
This patch was never applied. Should it be?
Can someone please review?
-Allen
On Wednesday 31 October 2007 14:05:41 Pascal Létourneau wrote:
> First, is it ok to send a (trivial) patch to this list for review or should it
> go to k-c-d?
>
> The "Open with" dialog doesn't work because it tries to interpret "kapp %u" as
> an url
>
> Pascal Létourneau
>
> Index: kio/kfile/kopenwithdialog.cpp
> ===================================================================
> --- kio/kfile/kopenwithdialog.cpp (revision 731370)
> +++ kio/kfile/kopenwithdialog.cpp (working copy)
> @@ -580,7 +580,7 @@ void KOpenWithDialogPrivate::init(const
> edit->button()->hide();
> }
>
> - edit->setUrl( KUrl(_value) );
> + edit->setPath( _value );
> edit->setWhatsThis(i18n(
> "Following the command, you can have several place holders which will be
> replaced "
> "with the actual values when the actual program is run:\n"
> @@ -677,7 +677,7 @@ void KOpenWithDialog::slotSelected( cons
> {
> kDebug(250)<<"KOpenWithDialog::slotSelected";
> KService::Ptr pService = d->curService;
> - d->edit->setUrl(KUrl(_exec)); // calls slotTextChanged :(
> + d->edit->setPath(_exec); // calls slotTextChanged :(
> d->curService = pService;
> }
>
> _______________________________________________
> Kdelibs-bugs mailing list
> Kdelibs-bugs at kde.org
> https://mail.kde.org/mailman/listinfo/kdelibs-bugs
>
More information about the Kdelibs-bugs
mailing list