[PATCH] KReplace - Prompt on replace broken

[Thomas McGuire]

Hi,

KReplace is broken for me, the prompt on replace dialog is never shown, 
because it has size 0.

To reproduce:
1. Open Konqueor on dot.kde.org, go to some story, and reply.
2. Enter "asdf" in the comment area
3. Right-click, then "Replace"
4. Text to find: "asdf". Make sure "Prompt on replace" is checked
5. You now should see a prompt dialog (Close/Replace/Skip/Cancel), but you 
don't, because that dialog has size 0 and is therefore invisible

The reason is resize(minimumSize()) in 
KReplaceNextDialog::KReplaceNextDialog(). minimumSize() here returns 0.

The attached patch simpy removes the line with resize(). The size seems to be 
correct nevertheless. I am not sure if that is the right fix, especially 
because David Faure couldn't reproduce it.

With this fix, Konqueror still crashes when the prompt dialog is closed 
though, from the backtrace it seems because some receiver, which is about the 
get a signal, is 0. I didn't really try to fix the problem, but I found out 
that commenting out delete m_replace; m_replace = 0; in 
khtml/rendering/render_form.cpp:1587 works around the problem. I guess the 
real problem is in KHTML, not KReplace, but I'm not sure.

OK to commit the attached patch?

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: replace.diff
Type: text/x-diff
Size: 407 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kdelibs-bugs/attachments/20071108/4a181bfb/attachment.bin