[Bug 151874] KIconLoader fails to cache some images

Aaron J.Seigo aseigo at kde.org
Mon Nov 5 19:06:39 CET 2007


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=151874         
aseigo kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From aseigo kde org  2007-11-05 19:06 -------
SVN commit 733164 by aseigo:

improve the speed of KIconLoader::loadIcon and iconPath dramatically.
for cached icons, this takes us from 22k icons/s to somewhere around 118k.

windows people: you still have the bane of QDir in this hot path, but i don't know what to replace it with that will work on windows. QDir is just too expensive to use in this hot path just to check for a relative or absolute path. if you know of a clever way to do this without resorting to QDir, please make the change in the appropriate ifdef areas. otherwise you'll only get about half the benefit here.

bug 151874: i still don't know if you're having issues with the caching of icons. please test with this rev and let me know if this helps at all.

CCMAIL:kde-window kde org
BUGS:151874


 M  +34 -36    kiconloader.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=733164


More information about the Kdelibs-bugs mailing list