[Kdelibs-bugs] [PATCH] Fixing KMessageBox cutoff texts

Andreas Pakulat apaku at gmx.de
Fri Nov 2 21:06:11 CET 2007


On Freitag, 2. November 2007, Aaron J. Seigo wrote:
> On Friday 02 November 2007, Andreas Pakulat wrote:
> > Unless I hear objections until monday I'm going to commit this as I
> > can't see any downside here (besides scrollbars, but I think thats
> > acceptable)
>
> since the scrollbars would only show on poorly formed messages, i
> think it is fine as well .. as long as they don't show up
> unnecessarily for reasonable messages (e.g. ones without
> huuuuuuuugelongrunningtexts), we should be ok.

Well, do you know of a "real world" example for testing? So far I just 
made up one string that has no word-separators and one that has tons of 
newlines so I have an extreme for both directions. 

The label itself does do word-wrapping and the dialog does get a bit 
bigger, well let me attach a screenshot. That dialog has about half the 
size of my screen in each direction so is effectively 1/4th of the 
whole screen size. The original code tried to make the width nor more 
than 1/3rd so the dialog is actually a bit larger now in the worst 
case.

Andreas

-- 
Blow it out your ear.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: error_box_long text1.png
Type: image/png
Size: 24875 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kdelibs-bugs/attachments/20071102/8100fd78/attachment-0001.png 


More information about the Kdelibs-bugs mailing list