[Kdelibs-bugs] [PATCH] Fixing KMessageBox cutoff texts

[Aaron J. Seigo]

On Thursday 01 November 2007, Andreas Pakulat wrote:
> On Donnerstag, 1. November 2007, Aaron J. Seigo wrote:
> > On Wednesday 31 October 2007, Andreas Pakulat wrote:
> > > Hi,
> > >
> > > just had a look why all KMessageBoxes cut off their text and the
> > > problem seems to be the width/height calculation code in
> > > KMessageBox::createKMessageBox and the fact that the result is set
> > > as Fixed Size for the label.
> > >
> > > I don't quite understand why the contents width/height is
> > > calculated in the first place, so I just disabled the whole stuff
> > > and set a real margin on the label instead of changing its size.
> > > Looks more apropriate to me.
> >
> > the point of this code was to prevent really long strings from
> > creating reaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaally wide
> > dialogs. it looks at the size of the screen that the dialog is on and
> > ensures it doesn't
>
> Ok, AFAICS this is for message boxes that don't have whitespace in them,
> or rather have a very very long part of the text without whitespace -
> like a deeply nested url...

exactly; these are pretty common in, for instance, konqueror...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kdelibs-bugs/attachments/20071101/0b208739/attachment.pgp