D26801: Really fix the Windows backend for KNotifications

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> notifybysnore.cpp:90
> +        KNotification *notification = m_notifications.value(id);
> +        if (notification == 0) {
>              qCDebug(LOG_KNOTIFICATIONS) << "Notification not found!";

if (!notification) or at least compare with nullptr
And remove the commented KNotificaion*

> vonreth wrote in notifybysnore.h:48
> m_notificationsRev
> m_counter
> 
> KDE and Qt uses cammelCase and member vars are prefixed with an "m_".
> 
> m_notifications it only used to see which notification was closed by a user interaction to snoretoast (this part i probably broken right now).
> There is no need to keep two maps.

now add white space around the = :)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20200121/f273e769/attachment.html>