D16491: Allow shares from desktop to be canceled

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added a comment.


  Tested on my OnePlus and it works well.
  
  +1 on not using AsyncTask.
  
  Building our own Job management system seems a bit like an overkill just for this, though, but hopefully we can use it in more places.

INLINE COMMENTS

> ShareNotification.java:77
>  
> -    public int getId() {
> +    public void setJobId(long jobId) {
> +        builder.mActions.clear();

Rename to addCancelButton or something like that? It does more than setting an id.

REVISION DETAIL
  https://phabricator.kde.org/D16491

To: eduisters, #kde_connect, nicolasfella, albertvaka
Cc: albertvaka, nicolasfella, kdeconnect, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190308/5ed18e6f/attachment.html>