D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above)

[Erik Duisters]

eduisters marked 2 inline comments as done.
eduisters added inline comments.

INLINE COMMENTS

> albertvaka wrote in SftpSettingsFragment.java:322
> I can write to the internal phone storage (sdcard0) on API 19, although it appears as read only because of this condition. Maybe you had a different experience while testing?
> 
> To simplify this code, since it's only for old APIs, maybe remove appending the "read only" string? It could be that every device is different, and determining if it is actually going to be read-only is difficult. If that's the case, I don't think it's worth trying to get it right just for old APIs.

I apparently did not test if writing to API 19 was possible. I just assumed that because writing to sdcard on KitKat was not possible using the File API it was also not possible using SaF.

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  arcpatch-D18212

REVISION DETAIL
  https://phabricator.kde.org/D18212

To: eduisters, #kde_connect, albertvaka, sredman
Cc: albertvaka, sredman, kdeconnect, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190308/0a6ce506/attachment.html>