D21602: Add NSIS Script for KDE Connect

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> kdeconnect-kde.py:33
> +        self.defines["caption"] = self.binaryArchiveName(fileType=None).capitalize()
>          self.defines["executable"] = "bin\\kdeconnect-indicator.exe"
>          self.defines["icon"] = os.path.join(os.path.dirname(__file__), "icon.ico")

I think you should not set the execuatable, firstly he key is deprecated use shortcuts instead and you handle the installation of shortcuts in "sections"

REPOSITORY
  R877 Craft Blueprints for KDE

BRANCH
  arcpatch-D21602

REVISION DETAIL
  https://phabricator.kde.org/D21602

To: brute4s99, vonreth, albertvaka, sredman
Cc: #craft, #kde_connect, ewentzel, dshelley, pawelkwiecinski, ctakano, vporvaznik, hoetzel, mschroeder, varunp, hechenlan, shivanshukantprasad, skymoore, fbampaloukas, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, bencreasy, domson, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, vonreth, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190618/390c542f/attachment.html>