D21602: Add NSIS Script for KDE Connect

[Hannah von Reth]

vonreth added a comment.


  we don't provide an option for custome uninstall icons and using the app icon would be confusing.
  
  maybe we should introduce un_sections to remove the shortcuts?

INLINE COMMENTS

> kdeconnect-kde.py:33
> +        self.defines["caption"] = self.binaryArchiveName(fileType=None).capitalize()
> +        self.defines["productname"] = "KDE Connect"
> +        self.defines["company"] = "KDE"

no need to set, default is display name

> kdeconnect-kde.py:34
> +        self.defines["productname"] = "KDE Connect"
> +        self.defines["company"] = "KDE"
> +        

just leave it to the default

REPOSITORY
  R877 Craft Blueprints for KDE

REVISION DETAIL
  https://phabricator.kde.org/D21602

To: brute4s99, vonreth, albertvaka, sredman
Cc: #craft, #kde_connect, ewentzel, dshelley, pawelkwiecinski, ctakano, vporvaznik, hoetzel, mschroeder, varunp, hechenlan, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, bencreasy, domson, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, vonreth, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190605/077778d8/attachment-0001.html>