D22585: Clipboard sync on new connections

[Simon Redman]

sredman added a reviewer: KDE Connect.
sredman added inline comments.

INLINE COMMENTS

> ClipboardListener.java:95
>  
> +    public String getCurrentContent(){
> +        return currentContent;

Space after `{`

> ClipboardPlugin.java:63
> +            return true;
> +        }else{
> +            return false;

Spaces

> ClipboardPlugin.java:76-77
>          NetworkPacket np = new NetworkPacket(ClipboardPlugin.PACKET_TYPE_CLIPBOARD);
>          np.set("content", content);
> +        np.set("timestamp", ClipboardListener.instance(context).getUpdateTimestamp());
>          device.sendPacket(np);

It would be nice to write down the packet format, especially since a new field has just appeared. I usually do this in a block comment on the packet type definition (`PACKET_TYPE_CLIPBOARD`)

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D22585

To: credman, #kde_connect
Cc: sredman, kdeconnect, ewentzel, dshelley, pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, fbampaloukas, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190720/e72aaaae/attachment.html>