D22584: Clipboard sync on new connection

[Simon Redman]

sredman added inline comments.

INLINE COMMENTS

> clipboardlistener.h:40
>      QString currentContent;
> +    qint64 updateTimestamp = 0;
>      QClipboard* clipboard;

Typically local variables are prefixed with `m_<varname>`, so like `m_updateTimestamp`. Of course, this should apply to `currentContent` as well...

> clipboardlistener.h:61-62
>  
> +    QString getCurrentContent();
> +    qint64 getUpdateTimestamp();
> +

Usually getters are just named `<varname>`, so like `qint64 updateTimestamp()`

> clipboardplugin.cpp:57
>  {
> +    if (np.has(QStringLiteral("timestamp"))){
> +        qint64 packetTime = np.get<qint64>(QStringLiteral("timestamp"));

Space before `{`

> clipboardplugin.cpp:72
> +        return true;
> +    }else{
> +        return false;

`} else {` (Spaces)

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D22584

To: credman
Cc: sredman, kdeconnect, ewentzel, dshelley, pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, fbampaloukas, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190720/e2f550dc/attachment.html>