D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above)

[Erik Duisters]

eduisters updated this revision to Diff 50069.
eduisters added a comment.


  - Properly handle the situation where no storage locations have been configured
  - Handle preference changes
  - Allow deleting of the last storage location
  - Always create the right FileSystemView depending on Build.VERSION
  - Remove erroneous leftover from re-fractoring SftpSettingsActivity into SftpSettingsFragment
  - Commented out entries needed to debug org.apache.sshd
  - Remove unused variables
  - Remove optional WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < KITKAT
  - Remove required WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < 23 at installation time and we now use SaF starting Build.VERSION >= 21
  - Remove unneeded PreferenceFragmentCompat.OnPreferenceStartScreenCallback
  - Show plugin as failed on KitKat and older devices when no sdcard is detected

REPOSITORY
  R225 KDE Connect - Android application

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18212?vs=49386&id=50069

BRANCH
  sftp_saf

REVISION DETAIL
  https://phabricator.kde.org/D18212

AFFECTED FILES
  build.gradle
  res/drawable/ic_arrow_drop_down_24px.xml
  res/drawable/ic_delete.xml
  res/layout/fragment_storage_preference_dialog.xml
  res/layout/preference_checkbox.xml
  res/menu/sftp_settings_action_mode.xml
  res/values/strings.xml
  res/values/styles.xml
  res/xml/sftpplugin_preferences.xml
  src/org/kde/kdeconnect/Helpers/StorageHelper.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/AndroidFileSystemFactory.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/AndroidFileSystemView.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/AndroidSafFileSystemView.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/AndroidSafSshFile.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/AndroidSshFile.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/RootFile.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpSettingsFragment.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/SimpleSftpServer.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/StoragePreference.java
  src/org/kde/kdeconnect/Plugins/SftpPlugin/StoragePreferenceDialogFragment.java
  src/org/kde/kdeconnect/UserInterface/DeviceSettingsActivity.java
  src/org/kde/kdeconnect/UserInterface/DeviceSettingsFragment.java
  src/org/kde/kdeconnect/UserInterface/PluginSettingsFragment.java

To: eduisters, #kde_connect
Cc: albertvaka, sredman, kdeconnect, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190122/c3e9c757/attachment.html>