D18354: Simplify notification handling

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added a comment.
This revision is now accepted and ready to land.


  LGTM, just two comments.

INLINE COMMENTS

> notificationsmodel.cpp:271-272
>  {
> -    //TODO only emit the affected indices
> -    Q_UNUSED(id);
>      Q_EMIT dataChanged(index(0,0), index(m_notificationList.size() - 1, 0));

I would keep the parameter and the TODO, or fix the dataChanged emit so it doesn't contain every row.

> notification.h:74
>      void replyRequested();
> -    void ready();
> +    Q_SCRIPTABLE void ready();
>  

Why Q_SCRIPTABLE?

REPOSITORY
  R224 KDE Connect

BRANCH
  noti

REVISION DETAIL
  https://phabricator.kde.org/D18354

To: nicolasfella, #kde_connect, broulik, albertvaka
Cc: albertvaka, kdeconnect, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190121/f1086935/attachment.html>