D18223: Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all

Albert Vaca Cintora noreply at phabricator.kde.org
Wed Jan 16 12:05:07 GMT 2019


albertvaka accepted this revision.
albertvaka added a comment.
This revision is now accepted and ready to land.


  Makes sense. Probably this was copied-and-pasted from another KIOslave.

INLINE COMMENTS

> kiokdeconnect.cpp:92
>  
> +//TODO: This must be old code because it's never called. I think there used to be an kdeconnect entry listing all the available devices
>  void KioKdeconnect::listAllDevices()

It can still be accessed through `kdeconnect://` without a device id following.

REPOSITORY
  R224 KDE Connect

BRANCH
  sftp_saf

REVISION DETAIL
  https://phabricator.kde.org/D18223

To: eduisters, #kde_connect, albertvaka
Cc: albertvaka, kdeconnect, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190116/f41eb560/attachment.html>


More information about the KDEConnect mailing list