D18181: Allow disabling persistent notification in Android 8.0 and up

[Erik Duisters]

eduisters requested changes to this revision.
eduisters added a comment.
This revision now requires changes to proceed.


  I think changing the title to "Persistent Notification" and summary to "Click to enable/disable in Notification settings" would be better for Oreo and newer

INLINE COMMENTS

> SettingsFragment.java:82
> +            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) 
> +            persistentNotif.setSummary(R.string.setting_persistent_notification_pie_description);
> +            else  

indentation

> SettingsFragment.java:84
> +            else  
> +            persistentNotif.setSummary(R.string.setting_persistent_notification_oreo_description);
> +            

indentation

> SettingsFragment.java:86
> +            
> +            persistentNotif.setOnPreferenceClickListener(new Preference.OnPreferenceClickListener() {
> +                public boolean onPreferenceClick(Preference preference) {

Can be replaced by a lambda (hover on Preference.OnPreferenceClickListener() and press Alt+enter)

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D18181

To: brute4s99, #kde_connect, eduisters
Cc: eduisters, nicolasfella, kdeconnect, #kde_connect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190112/f5439ae8/attachment.html>