D18181: Allow disabling persistent notification in Android 8.0 and up

[Erik Duisters]

eduisters requested changes to this revision.
eduisters added a comment.
This revision now requires changes to proceed.


  The "Show persistent notifications" switch should represent reality. If it's on the notification should be displayed and if it's off the notification should not be visible.

INLINE COMMENTS

> SettingsFragment.java:94
> +                Intent intent = new Intent();
> +                if(android.os.Build.VERSION.SDK_INT > Build.VERSION_CODES.N_MR1){
> +                    intent.setAction("android.settings.APP_NOTIFICATION_SETTINGS");

Why this if/else? You already tested for O above

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D18181

To: brute4s99, #kde_connect, eduisters
Cc: eduisters, nicolasfella, kdeconnect, #kde_connect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190111/b518f94d/attachment-0001.html>