D18181: Allow disabling persistent notification in Android 8.0 and up

Nicolas Fella noreply at phabricator.kde.org
Fri Jan 11 12:19:42 GMT 2019


nicolasfella added inline comments.

INLINE COMMENTS

> SettingsFragment.java:94
>              final boolean isChecked = (Boolean)newValue;
> -            NotificationHelper.setPersistentNotificationEnabled(context, isChecked);
> -            BackgroundService.RunCommand(context, service -> service.changePersistentNotificationVisibility(isChecked));
> +            if ((Build.VERSION.SDK_INT >= Build.VERSION_CODES.P || Build.VERSION.SDK_INT >= Build.VERSION_CODES.O)) {
> +                Intent intent = new Intent();

Build.VERSION.SDK_INT >= Build.VERSION_CODES.O should be enough

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D18181

To: brute4s99, #kde_connect
Cc: nicolasfella, kdeconnect, #kde_connect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190111/35a33d51/attachment.html>


More information about the KDEConnect mailing list