D17627: Simplify receiving multiple files using only 1 notification

Albert Vaca Cintora noreply at phabricator.kde.org
Mon Jan 7 10:52:55 GMT 2019


albertvaka accepted this revision.
albertvaka added inline comments.

INLINE COMMENTS

> SharePlugin.java:214
> +            if (hasNumberOfFiles && !hasOpen) {
> +                receiveFileRunnable = runnable;
>              }

Why only save it if it hasNumberOfFiles? If I understand correctly, we could still add more files to it from another networkpacket.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D17627

To: eduisters, #kde_connect, nicolasfella, albertvaka
Cc: albertvaka, nicolasfella, kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190107/e5b9a754/attachment-0001.html>


More information about the KDEConnect mailing list