D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11

[Erik Duisters]

eduisters added inline comments.

INLINE COMMENTS

> FindMyPhoneSettingsFragment.java:75
> +        /*
> +         * There is not RingtonePreference in support library nor androidx, this is the workaround proposed here:
> +         * https://issuetracker.google.com/issues/37057453

Typo: not => no

> PluginSettingsFragment.java:59
> +        if (getArguments() == null || !getArguments().containsKey(ARG_PLUGIN_KEY)) {
> +            throw new RuntimeException("You must call provide a pluginKey by calling setArguments(@NonNull String pluginKey)");
> +        }

Typo: delete call

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  replace_preference_activity

REVISION DETAIL
  https://phabricator.kde.org/D17859

To: eduisters, #kde_connect, nicolasfella
Cc: kdeconnect, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190105/c5ea5b5b/attachment-0001.html>