D17790: Port away from QCA
Nicolas Fella
noreply at phabricator.kde.org
Fri Feb 8 22:34:10 GMT 2019
nicolasfella planned changes to this revision.
nicolasfella added a comment.
GGotta add a runtime check in cmake for packages.
INLINE COMMENTS
> kdeconnectconfig.cpp:201
> + if (retVal) {
> + qWarning(KDECONNECT_CORE) << "Could not generate certificate";
> }
Daemon::reportError
> testsslsocketlinereader.cpp:177
>
> - setSocketAttributes(serverSocket, QStringLiteral("Test Server"));
> - setSocketAttributes(m_clientSocket, QStringLiteral("Test Client"));
> + setSocketAttributes(serverSocket, QStringLiteral("foo"));
> + setSocketAttributes(m_clientSocket, QStringLiteral("foo"));
????
> testsslsocketlinereader.cpp:291
>
> - QCA::CertificateOptions certificateOptions(QCA::PKCS10);
> - certificateOptions.setSerialNumber(10);
> - certificateOptions.setInfo(certificateInfo);
> - certificateOptions.setValidityPeriod(startTime, endTime);
> - certificateOptions.setFormat(QCA::PKCS10);
> + QProcess::execute("openssl", QStringLiteral("req -new -x509 -sha256 -newkey rsa:2048 -nodes -keyout %1 -days 3650 -out %2 -subj /O=KDE/OU=KDEConnect/CN=%3").arg(priv.fileName(), cert.fileName(), deviceName).split(" "));
>
break into a couple of lines.
REPOSITORY
R224 KDE Connect
REVISION DETAIL
https://phabricator.kde.org/D17790
To: nicolasfella, #kde_connect
Cc: kdeconnect, sredman, albertvaka, pino, apol, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190208/3fae8377/attachment-0001.html>
More information about the KDEConnect
mailing list