D15414: use libkeepalive to wakeup daemon

Albert Vaca Cintora noreply at phabricator.kde.org
Sat Sep 22 13:09:43 BST 2018


albertvaka accepted this revision.
albertvaka added a comment.
This revision is now accepted and ready to land.


  Looks good to me, but I can't test the sailfish part.
  
  I think you should take the role of maintainer for the SFOS parts of kdeconnect :) So, I would say: either merge patches to the SF part directly without review, or add as a reviewer someone more knowledgeable about SFOS than us. I feel like I'm blocking progress on the SF port and can't add much.

INLINE COMMENTS

> lanlinkprovider.cpp:356
>  
> -    //qCDebug(KDECONNECT_CORE) << "LanLinkProvider received reply:" << data;
> +    qCDebug(KDECONNECT_CORE) << "LanLinkProvider received reply:" << data;
>  

Don't push those uncomments, they will print a lot of spam.

REPOSITORY
  R224 KDE Connect

BRANCH
  fixup-crash

REVISION DETAIL
  https://phabricator.kde.org/D15414

To: piggz, #kde_connect, nicolasfella, albertvaka
Cc: kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180922/fa1d950c/attachment.html>


More information about the KDEConnect mailing list