D15608: [Desktop] Prevent SMS app from requesting entire contents of every conversation

[Simon Redman]

sredman marked 2 inline comments as done.
sredman added inline comments.

INLINE COMMENTS

> apol wrote in conversationsdbusinterface.cpp:53
> Looks like it's casting twice? How about `toReturn += conversation.cbegin()->toVariant()`?
> Also we probably should make sure it's not empty.

The double cast was because I was trying to resolve a (different) issue. Good catch on the "null" dereference, thank you!

> apol wrote in conversationsdbusinterface.cpp:79
> Should probably offset it by start?

I forgot I could use a different dbus viewer to make the call: Now I have been able to test this and it appears to work!

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D15608

To: sredman, #kde_connect
Cc: apol, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180920/ff8bb954/attachment-0001.html>