D15543: [Desktop] SMS plugin no longer creates desktop notifications -- Old functionality still supported by notifications plugin

[Simon Redman]

sredman added inline comments.

INLINE COMMENTS

> nicolasfella wrote in smsplugin.cpp:58
> Theoretically the check is not necessary since this is the only packet type that is supported

True, but not checking packet type is part of how we got into the mess with the Telephony plugin 😬

REPOSITORY
  R224 KDE Connect

BRANCH
  sms-packet-update

REVISION DETAIL
  https://phabricator.kde.org/D15543

To: sredman, #kde_connect, albertvaka, nicolasfella
Cc: nicolasfella, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180916/020672fe/attachment-0001.html>