D15543: [Desktop] SMS plugin no longer creates desktop notifications -- Old functionality still supported by notifications plugin

[Simon Redman]

sredman created this revision.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.

REVISION SUMMARY
  Drop support for creating notifications from the SMS plugin. The old usecase is better handled by the notifications plugin reply box anyway
  
  Rename packets defined in SMS plugin from PACKET_TYPE_TELEPHONY_* to PACKET_TYPE_SMS_*
  
  Update TELEPHONY plugin packet description to point to SMS plugin
  
  Define TELEPHONY_REQUEST_MUTE packet to replace old TELEPHONY_REQUEST with mute event field

TEST PLAN
  I see four test cases, based on the version of the app being used, where "old" means any version built with sources not containing this revision and "new" means any version built with sources using this revision:
  
  - New Android vs. New Desktop
    - Supported and works for me
  - New Android vs. Old Desktop
    - Supported and works for me
  - Old Android vs. New Desktop
    - Not supported - Download a new app from the Play store or F-Droid
  - Old Android vs. Old Desktop
    - If this is broken, it is not my fault :)
  
  In the supported use cases:
  
  - Test SMS reply
    - Receive SMS (or MMS!) message
    - Verify that the //notification// plugin forwards a replyable notification and that replying works
  - Test incoming call ringer mute
    - Enable ringer volume (not vibrate)
    - Receive phone call
    - Verify a desktop notification with a Mute button appears
    - Verify that clicking the mute button causes the phone to stop making the ringer noise (vibration not affected)

REPOSITORY
  R224 KDE Connect

BRANCH
  sms-packet-update

REVISION DETAIL
  https://phabricator.kde.org/D15543

AFFECTED FILES
  plugins/sms/kdeconnect_sms.json
  plugins/sms/smsplugin.cpp
  plugins/sms/smsplugin.h
  plugins/telephony/kdeconnect_telephony.json
  plugins/telephony/telephonyplugin.cpp
  plugins/telephony/telephonyplugin.h

To: sredman
Cc: kdeconnect, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180915/053382dc/attachment.html>