D15409: [WIP] Allow SMS app to handle newly recieved messages
Simon Redman
noreply at phabricator.kde.org
Mon Sep 10 16:41:58 BST 2018
sredman created this revision.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.
REVISION SUMMARY
Update sms app model to use new conversationUpdated signal
Filter incoming messages which belong to a different conversation than the one currently being viewed
Ideally, the Android side should be updated to send a packet on a newly *sent* messages as well. If the user types a message on the phone while the desktop SMS app is running, it would be nice to reflect that. I do not think this will require any changes on the desktop side, but it would be best to get Android working to verify this assumption.
TODO: Dump support for old-style Telephony SMS packets, since the phone now sends new-style as well
TODO: Figure out how to snoop *sent* message on Android and forward those as well
TEST PLAN
This patch relies on D15360 <https://phabricator.kde.org/D15360> for Android-side support
- Positive case:
- Open a conversation in the SMS app
- Receive a new message into that conversation (text yourself?)
- Verify that the new message appears at the bottom of the appropriate conversation
- Negative case:
- Open a conversation in the SMS app
- Receive a new message into a different conversation (text yourself?)
- Verify that the new message does *not* appear in the open conversation
REPOSITORY
R224 KDE Connect
BRANCH
sms-synchro
REVISION DETAIL
https://phabricator.kde.org/D15409
AFFECTED FILES
plugins/sms/conversationsdbusinterface.cpp
plugins/sms/conversationsdbusinterface.h
plugins/sms/kdeconnect_sms.json
smsapp/conversationmodel.cpp
smsapp/conversationmodel.h
To: sredman
Cc: kdeconnect, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, marcorichetta, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180910/8671976b/attachment-0001.html>
More information about the KDEConnect
mailing list