D16553: Cache and delete old ConversationsDbusInterfaces to avoid memory leak

[Simon Redman]

sredman created this revision.
sredman added a reviewer: KDE Connect.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.

REVISION SUMMARY
  After using the ConversationsDbusInterface for a little while, there can be significant (MBs) memory usage of cached messages. The QDBusAbstractAdaptor does not like to be manually deleted, but it looks like it is safe to do so after constructing a new one
  
  This contradicts the comment in the BatteryPlugin and the BatteryDbusInterface, which says deletelater() is not safe. Has Qt been updated since then?

TEST PLAN
  - Run daemon
  - Hopefully experience no crashes after many phone reconnects

REPOSITORY
  R224 KDE Connect

BRANCH
  ConversationsDbusMemoryLeak

REVISION DETAIL
  https://phabricator.kde.org/D16553

AFFECTED FILES
  plugins/sms/smsplugin.cpp
  plugins/sms/smsplugin.h

To: sredman, #kde_connect
Cc: kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181031/57270c3e/attachment.html>