D16534: [SMS App] Clean up runtime warning about undefined behavior
Simon Redman
noreply at phabricator.kde.org
Tue Oct 30 20:11:42 GMT 2018
sredman created this revision.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.
REVISION SUMMARY
Move ColumnLayout containing text elements inside of the graphical bounding rectangle
TEST PLAN
Pre patch:
- Launch messaging app
- Open conversation
- Notice huge spew of warnings like: "qrc:/qml/ChatMessage.qml:84:5: QML ColumnLayout: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead."
Post patch:
- Launch messaging app
- Open conversation
- No warnings about undefined behavior
REPOSITORY
R224 KDE Connect
BRANCH
anchor-warning
REVISION DETAIL
https://phabricator.kde.org/D16534
AFFECTED FILES
smsapp/qml/ChatMessage.qml
To: sredman
Cc: kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181030/cb24215e/attachment.html>
More information about the KDEConnect
mailing list