D16518: Simplify pairing from notification
Erik Duisters
noreply at phabricator.kde.org
Tue Oct 30 10:52:06 GMT 2018
eduisters added a comment.
In D16518#350722 <https://phabricator.kde.org/D16518#350722>, @nicolasfella wrote:
> Is there any visible behavior change?
No, there are no visible behavior changes. Also see my inline comments
INLINE COMMENTS
> DeviceFragment.java:378
> - frag.device = dev;
> - frag.device.acceptPairing();
> -
This is the only line that actually does anything in this method
> DeviceFragment.java:405
> - activity.onDeviceSelected(null);
> -
> - frag.refreshUI();
The above 2 lines are the ones that actually do something in the method
REPOSITORY
R225 KDE Connect - Android application
REVISION DETAIL
https://phabricator.kde.org/D16518
To: eduisters, #kde_connect
Cc: nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181030/3942f7a8/attachment.html>
More information about the KDEConnect
mailing list